Show native plugin info in the effect selection dialog #1985
Conversation
The effect selection dialog now also shows the information for the native plugins. This included name, description, author as well as the plugin icon. Also removed the group box with the title "Plugin description" because it should be rather obvious to the user that further information about the plugin is shown. This removes some clutter from the dialog.
|
With this patch the dialog now looks as follows on my system: |
|
I like this idea. It's useful to have description/author info for native plugins. I just tested your change, and it works fine on my system (Ubuntu 14.10, x86_64). As for the icons, literally all but four of my plugins have that same one shown in your screenshot. And the other four simply don't have icons. But note that I haven't installed any plugins not distributed with lmms. |
|
Yes, unfortunately all plugins seem to have the same icon. Perhaps showing them in the dialog will motivate some artists to create individual icons for the effects to give them more character. 🎨 😃 |
Agreed. |
|
I like this. A nice improvement. It would be nice if all these Icons were designed by the same person, so there is some consistency. |
|
|
||
| hbox->addWidget(textualInfoWidget); | ||
|
|
||
| QVBoxLayout * textWidgetLayout = new QVBoxLayout( textualInfoWidget); |
There was a problem hiding this comment.
I much prefer the name textWidgetLayout to the old one l 👍
There was a problem hiding this comment.
Thanks! I think in times of IDEs with autocompletion variable names like l should be made a thing of the past. :)
|
I just tested this, and looked over the code, every thing looks good to me. |
Show native plugin info in the effect selection dialog
The effect selection dialog now also shows the information for the native
plugins. This included name, description, author as well as the plugin
icon.
Also removed the group box with the title "Plugin description" because
it should be rather obvious to the user that further information about
the plugin is shown. This removes some clutter from the dialog.